Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set codecov #1564

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Set codecov #1564

merged 2 commits into from
Mar 5, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Mar 5, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ternaus - Here's my review!

General suggestions:

  • Consider specifying a minimum coverage threshold to ensure code quality standards are met.
  • Explore the possibility of more granular control over which directories or files pytest should cover for more effective identification of untested code.
  • Enhance the utility of coverage reports by adding flags or paths to categorize them, especially useful for larger projects.
  • Verify the correctness of the Codecov slug to ensure coverage reports are uploaded to the correct repository.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link

codecov bot commented Mar 5, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@ternaus ternaus merged commit 9e61897 into main Mar 5, 2024
19 checks passed
@ternaus ternaus deleted the set_codecov branch March 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant