Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleeve multi-work is implemented! #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShawnPatton
Copy link
Contributor

It's a bit messier than I would like, and doesn't do any of the fancy augment logic from work-for-factions.js, but I'm already seeing massive gains early in my current run. The options for the stochastic balancing of work/crime were a late patch I added just now, but should prevent us from delaying gangs too much when we've got lots of factions.

…eeded. Option for first sleeve to always mimic the player's work, per previous versions.
@alainbryden
Copy link
Owner

Thanks for the contribution. For the sake of those who blindly run my scripts without reading the source code, I won't merge anything along these lines until danielyxie/bitburner#2832 is fixed

@ShawnPatton
Copy link
Contributor Author

UPDATE on danielyxie/bitburner#2832: This is not harmless. It appears to cause some form of save corruption on an individual sleeve, breaking any use of getSleevePurchasableAugs on them as well as whatever equivalent the UI uses. The Sleeves tab will not show their purchasable augs, but they can be bought via script if the name is hardcoded or retrieved from somewhere else. Currently digging for the root cause of both prongs of the issue, and/or some kind of save edit that will fix it. Not sure if finishing the bitnode will fix it.

@archraziel archraziel mentioned this pull request Feb 8, 2022
@archraziel
Copy link

This was fixed on danielyxie/bitburner#3070

@ShawnPatton
Copy link
Contributor Author

I've got an uncommitted tweak for ignoring some other invalid faction names. I'll try to get the cleaned up final version ready, when I have time.

@alainbryden alainbryden added the work-in-progress not ready for merge label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress not ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants