-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused Borrow trait requirements #53
Open
peter-scholtens
wants to merge
7
commits into
al8n:main
Choose a base branch
from
peter-scholtens:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 24, 2023
-
Use owned variables in examples (al8n#49)
* Cache takes ownership of input data The cache example now owns the data, and not static references, as mentioned in al8n#48 Also variable names are modified to explain their usage. * Update sync_example.rs The cache example now owns the data, and not static references, as mentioned in al8n#48 Also variable names are modified to explain their usage.
Configuration menu - View commit details
-
Copy full SHA for b161a98 - Browse repository at this point
Copy the full SHA b161a98View commit details
Commits on Apr 26, 2023
-
Specify number of entries parameter as (usize) integer (al8n#51)
While reviewing the code I was a confused by the name num_entries which suggest an integer while actually a fractional number is used. Changing this to usize makes the function call 7 machine code instructions shorter and the function body longer 5 instructions longer (from 65 to 70, as checked by the compiler explorer https://godbolt.org/ ). So with improved code readability also 2 instructions less are needed.
Configuration menu - View commit details
-
Copy full SHA for e89d308 - Browse repository at this point
Copy the full SHA e89d308View commit details
Commits on May 4, 2023
-
Copying of all fields of Self is replaced with modification of only m…
…odifying field of interest (al8n#52)
Configuration menu - View commit details
-
Copy full SHA for 18a12c9 - Browse repository at this point
Copy the full SHA 18a12c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc28dda - Browse repository at this point
Copy the full SHA cc28ddaView commit details
Commits on Nov 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8cd619 - Browse repository at this point
Copy the full SHA c8cd619View commit details
Commits on Dec 18, 2023
-
Increased waiting time by three
A single character contribution.
Configuration menu - View commit details
-
Copy full SHA for d350418 - Browse repository at this point
Copy the full SHA d350418View commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34e6023 - Browse repository at this point
Copy the full SHA 34e6023View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.