Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and a simpler build process #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gaetanlhf
Copy link
Contributor

This small PR offers:

  • Upgrading of dependencies,
  • A simpler build process thanks to a revised Makefile,
  • And of course an updated README.md, linked to the Makefile modification.

What do you think about this?

@akhenakh
Copy link
Owner

Nice work. Thanks.

I have a working branch around to use the xapian indexes from the zim files.

I'll check if it's compatible with those changes especially around cgo since a c++ binding is involved.

@gaetanlhf
Copy link
Contributor Author

Well, it's a good idea to reuse the indexes already present in the Zim files. :)
I guess you won't be using Bleve anymore? In that case, this PR is not very interesting, I will do one again when your modifications will be merged.

@akhenakh
Copy link
Owner

We want to keep the bleve indexer for zim files not containing xapian indexes, and for non cgo env.

So we will keep both solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants