Fix ros commands failing due to missing dylibs in macos with SIP enabled

src/catkin.ts

@@ -1,5 +1,5 @@
 import * as extension from "./extension";
-import * as cp from "child_process";
+import * as cp from "./child_process";
 import * as vscode from "vscode";
 
 /**

src/child_process.ts

@@ -0,0 +1,33 @@
+import * as cp from 'child_process';
+
+
+function wrapCommand(command: string, env?: any) {
+  if (!env) {
+    return command;
+  }
+
+  const passThroughCommand = Object.keys(env)
+    .filter(k => k.startsWith('DYLD'))
+    .reduce((cmd, key) => `${cmd ? `${cmd} &&` : ''} export ${key}='${env[key]}'`, '');
+
+  return passThroughCommand ? `${passThroughCommand} && ${command}` : command;
+}
+
+/*
+ * HACK: Apple SIP will not allowing passing through DYLD_* environment variables to 
+ * secured binaries like /bin/sh. This prevents certain commands like rospack list
+ * to fail due to missing dylib. This function will prepend export DYLD_*=value
+ * before command to bypass this issue.
+ */
+export function exec(command: string, options?: cp.ExecOptions, 
+  callback?: (error: Error, stdout: string, stderr: string) => void) : cp.ChildProcess {
+  if (!options || !options.env || process.platform != 'darwin') {
+    return cp.exec(command, options, callback);
+  }
+
+  return cp.exec(wrapCommand(command, options.env), options, callback);
+}
+
+export function spawn(command: string, args?: ReadonlyArray<string>, options?: cp.SpawnOptions): cp.ChildProcess {
+  return cp.spawn(command, args, options);
+}

src/master.ts

@@ -1,7 +1,7 @@
 import * as constants from "./constants";
 import * as extension from "./extension";
 import * as pfs from "./promise-fs";
-import * as cp from "child_process";
+import * as cp from "./child_process";
 import * as _ from "underscore";
 import * as vscode from "vscode";
 import * as xmlrpc from "xmlrpc";

src/utils.ts

@@ -1,6 +1,6 @@
 import * as extension from "./extension";
 import * as pfs from "./promise-fs";
-import * as cp from "child_process";
+import * as cp from "./child_process";
 import * as _ from "underscore";
 import * as vscode from "vscode";
 
@@ -26,7 +26,7 @@ export function sourceSetupFile(filename: string, env?: any): Promise<any> {
           }
 
           return env;
-        }, {}));
+        }, env));
       } else {
         reject(err);
       }