Merge pull request pkp#8497 from NateWr/i8051_submission_checklist

pkp#8051 Improve default author guidelines and submission che…
ajnyga · Dec 15, 2022 · 17fc81e · 17fc81e
2 parents e4cf161 + 4cdcee0
commit 17fc81e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
@@ -492,6 +492,7 @@ Cypress.Commands.add('assignParticipant', (role, name, recommendOnly) => {
 	cy.get('select[name=filterUserGroupId').select(role);
 	cy.get('input[id^="namegrid-users-userselect-userselectgrid-"]').type(names[1], {delay: 0});
 	cy.get('form[id="searchUserFilter-grid-users-userselect-userselectgrid"]').find('button[id^="submitFormButton-"]').click();
+	cy.waitJQuery();
 	cy.get('td:contains("' + name + '")').parents('tr').find('input[name="userId"]').check();
 	if (recommendOnly) cy.get('input[name="recommendOnly"]').click();
 	cy.flushNotifications();

diff --git a/schemas/context.json b/schemas/context.json
@@ -57,6 +57,7 @@
 		"authorGuidelines": {
 			"type": "string",
 			"multilingual": true,
+			"defaultLocaleKey": "default.contextSettings.authorGuidelines",
 			"validation": [
 				"nullable"
 			]

diff --git a/templates/frontend/pages/submissions.tpl b/templates/frontend/pages/submissions.tpl
@@ -34,27 +34,26 @@
 		{/if}
 	</div>
 
-	{if $submissionChecklist}
-		<div class="submission_checklist">
-			<h2>
-				{translate key="about.submissionPreparationChecklist"}
-				{include file="frontend/components/editLink.tpl" page="management" op="settings" path="workflow" anchor="submission/submissionChecklist" sectionTitleKey="about.submissionPreparationChecklist"}
-			</h2>
-			{translate key="about.submissionPreparationChecklist.description"}
-			{$submissionChecklist}
-		</div>
-	{/if}
-
 	{if $currentContext->getLocalizedData('authorGuidelines')}
 	<div class="author_guidelines" id="authorGuidelines">
 		<h2>
 			{translate key="about.authorGuidelines"}
-			{include file="frontend/components/editLink.tpl" page="management" op="settings" path="workflow" anchor="submission/authorGuidelines" sectionTitleKey="about.authorGuidelines"}
+			{include file="frontend/components/editLink.tpl" page="management" op="settings" path="workflow" anchor="submission/instructions" sectionTitleKey="about.authorGuidelines"}
 		</h2>
 		{$currentContext->getLocalizedData('authorGuidelines')}
 	</div>
 	{/if}
 
+	{if $submissionChecklist}
+		<div class="submission_checklist">
+			<h2>
+				{translate key="about.submissionPreparationChecklist"}
+				{include file="frontend/components/editLink.tpl" page="management" op="settings" path="workflow" anchor="submission/instructions" sectionTitleKey="about.submissionPreparationChecklist"}
+			</h2>
+			{$submissionChecklist}
+		</div>
+	{/if}
+
 	{foreach from=$sections item="section"}
 		{if $section->getLocalizedPolicy()}
 			<div class="section_policy">