Show how many tokens a user has delegated #82
Conversation
| @@ -62,10 +63,14 @@ export function handleDelegateVotesChanged( | |||
| entity.blockTimestamp = event.block.timestamp | |||
| entity.transactionHash = event.transaction.hash | |||
|
|
|||
| const delegator = loadOrCreateAccount(entity.delegator) | |||
| delegator.tokensDelegatedFrom = entity.newBalance | |||
There was a problem hiding this comment.
Should this be new - prev? Current approach would reflect the total amount including others
There was a problem hiding this comment.
There should be no "others"; a user can only delegate their current balance.
There was a problem hiding this comment.
I was under the impression that DelegateVotesChanged shows the new total delegated amount a delegate has across all delegations. If so, setting delegator.tokensDelegatedFrom would then show the total delegated amount available to the delegatee inclusive of the delegator and others.
| const delegateId = addressToBytes(event.params.delegate) | ||
| const delegate = loadOrCreateAccount(delegateId) | ||
| delegate.tokensDelegated = delegate.tokensDelegated.plus(changeInBalance) | ||
| delegate.tokensDelegatedTo = delegate.tokensDelegatedTo.plus(changeInBalance) |
There was a problem hiding this comment.
Wouldn't this value just be equivalent to newBalance?
There was a problem hiding this comment.
Here I just renamed tokensDelegated to tokensDelegatedTo; no change in logic.
There was a problem hiding this comment.
Yup, but was just suggesting that we could simplify the logic by setting to just newBalance, but not a big deal
src/mappings/ajna-token.ts
Outdated
| @@ -53,6 +53,7 @@ export function handleDelegateVotesChanged( | |||
| let entity = new DelegateVotesChanged( | |||
| event.transaction.hash.concatI32(event.logIndex.toI32()) | |||
| ) | |||
| entity.delegator = event.transaction.from | |||
There was a problem hiding this comment.
I think I got this line wrong; delegator should be event.transaction.to.
| @@ -53,6 +53,7 @@ export function handleDelegateVotesChanged( | |||
| let entity = new DelegateVotesChanged( | |||
| event.transaction.hash.concatI32(event.logIndex.toI32()) | |||
| ) | |||
| entity.delegator = event.transaction.to! | |||
There was a problem hiding this comment.
We cannot use from because it's the sender, not the recipient. We cannot use to because it is the token address. How do we determine the delegator?
There was a problem hiding this comment.
This event is always emitted concurrently with DelegateChanged or transfer so we can try to look at the event emitted in the same block at the correct log index
There was a problem hiding this comment.
We adopted a similar approach for handling AuctionSettle and AuctionNFTSettle
|
This implementation does not make sense. There is no real concept of "number of tokens delegated". |
Enhancements
Accountentity with a field showing how many tokens the user has delegated (to themselves, or to another delegated voter)DelegateVotesChangedto reveal the delegator (user who delegated)