Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collateral scale issue #64

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Collateral scale issue #64

merged 5 commits into from
Aug 28, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Aug 28, 2023

Conditional check of pool type was not working properly, although the poolType string was set correctly. Discovered in AssemblyScript, === performs a reference comparison, the opposite behavior of the operator in JavaScript.

Tested the fix on parvati. Unrelated, corrected the release candidate version in deployment script.

Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit 7a4d040 into develop Aug 28, 2023
1 check passed
@EdNoepel EdNoepel deleted the collateral-scale-issue branch August 28, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants