Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some issues found during deployment #63

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Fixed some issues found during deployment #63

merged 5 commits into from
Aug 24, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Aug 24, 2023 •
edited
Loading

  • Needed ERC721 ABI in ERC20 pool template
  • Fixed issue handling bucket indexes in handleRedeemPosition
  • Added bucket.save to persist changes in saveOrRemovePositionLend
  • Eliminate redundant RPC calls from getPoolForToken when handling memorialize/redeem

MikeHathaway
MikeHathaway approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@EdNoepel EdNoepel merged commit 806565f into develop Aug 24, 2023
1 check passed
@EdNoepel EdNoepel deleted the fix-deploy branch August 24, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway