fix tokensRequested #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHathaway
commented
Jul 27, 2023
| @@ -800,7 +800,7 @@ type DistributionPeriod @entity { | |||
| screeningVotesCast: BigDecimal! # number of screening votes cast | |||
| votes: [DistributionPeriodVote!]! # Voter info for the distribution period | |||
| proposals: [Proposal!]! # List of proposals submitted in the distribution period | |||
| totalTokensRequested: BigDecimal! # Total ajna tokens requested by all proposals in the distribution period | |||
There was a problem hiding this comment.
We can readd this as an alternative implementation showing the totalTokensRequested of the current list of proposals in the top funded slate
EdNoepel
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Changes look good, but let's leave this open until we've had a chance to debug with @joseherradezVS .
|
Tested on |
Fixed the unit tests by hardcoding the encoded proposal params as suggested. |
EdNoepel
reviewed
Aug 1, 2023
Added comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.