Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparations for ERC721 pools #31

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Preparations for ERC721 pools #31

merged 1 commit into from
Jul 20, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Jul 14, 2023 •
edited
Loading

Changes

  • Cleaned up the schema to use a single factory object.
  • Identify token type and pool type using a String.
  • Eliminate factory address table from constants.

This enables queries like the following:
image

@EdNoepel EdNoepel marked this pull request as draft July 14, 2023 20:20
@EdNoepel EdNoepel marked this pull request as ready for review July 14, 2023 20:32
MikeHathaway
MikeHathaway approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prateek105
prateek105 reviewed Jul 20, 2023
View reviewed changes
subgraph.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these address changes are for local testing, should we commit these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine; the addresses are overwritten by the build process.

prateek105
prateek105 approved these changes Jul 20, 2023
View reviewed changes
Copy link

@prateek105 prateek105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. added a comment.

@EdNoepel EdNoepel merged commit f15f26d into develop Jul 20, 2023
1 check passed
@EdNoepel EdNoepel deleted the 1415 branch July 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek105 prateek105 prateek105 approved these changes

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdNoepel @prateek105 @MikeHathaway