[BugFix][DevOps]do not save job instance in query mode (DataLinkDC#3880)

Signed-off-by: Zzm0809 <[email protected]> Co-authored-by: Zzm0809 <[email protected]>
aiwenmo · Oct 18, 2024 · 31bfa91 · 31bfa91
1 parent c081c3d
commit 31bfa91
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/dinky-admin/src/main/java/org/dinky/job/handler/Job2MysqlHandler.java b/dinky-admin/src/main/java/org/dinky/job/handler/Job2MysqlHandler.java
@@ -180,8 +180,11 @@ public boolean success() {
         history.setClusterId(clusterId);
         historyService.updateById(history);
 
-        if (job.getJobConfig().isStatementSet()
-                && (Asserts.isNullCollection(job.getJids()) || Asserts.isNullString(job.getJobManagerAddress()))) {
+        if (!job.getJobConfig().isStatementSet()) {
+            return true;
+        }
+
+        if (Asserts.isNullCollection(job.getJids()) || Asserts.isNullString(job.getJobManagerAddress())) {
             throw new BusException("The JobID or JobManagerAddress is null. ");
         }
 
@@ -190,9 +193,7 @@ public boolean success() {
         jobInstance.setClusterId(clusterId);
         jobInstance.setTaskId(taskId);
         jobInstance.setName(job.getJobConfig().getJobName());
-        if (Asserts.isNotNullCollection(job.getJids())) {
-            jobInstance.setJid(job.getJids().get(0));
-        }
+        jobInstance.setJid(job.getJids().get(0));
         jobInstance.setStep(job.getJobConfig().getStep());
         jobInstance.setStatus(JobStatus.INITIALIZING.getValue());
         jobInstanceService.save(jobInstance);