Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove need to configure const fields; add defaults #40

Closed
wants to merge 1 commit into from
Closed

feat: remove need to configure const fields; add defaults #40

wants to merge 1 commit into from

Conversation

ThomasRooney
Copy link
Contributor

  • All JSON Schema types marked as const now prefill attributes in terraform resources, and are not configurable.
  • All JSON Schema types marked as default now prefill attributes in terraform resources.
  • This reduces the amount of configuration needed for each user of the provider.
  • When the new provider was run in a debugger, state was migrated across without error. Leaving a const attribute set is a NOOP. Removing the attribute is also a NOOP: no infrastructure changes occur. This implied this is a non-breaking change to all existing users: however it would be good to verify beyond examples/pokeapi.

@ThomasRooney ThomasRooney changed the title feat: upgrade to latest terraform generator with prefilled fields: lowers configuration needed feat: remove need to configure const fields; add defaults Oct 5, 2023
@ThomasRooney
Copy link
Contributor Author

Note: to be batched with other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgroff bgroff Awaiting requested review from bgroff

@JonsSpaghetti JonsSpaghetti Awaiting requested review from JonsSpaghetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThomasRooney