chore: Makefile improvements #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change accomplishes the following in the `Makefile`: * Switches the `speakeasy` target `speakeasy` CLI command from `generate sdk` to `run`. This is recommended to ensure all generation features run as expected, such as Terraform provider code compilation. * Removes the `docs` target from the default target. The compilation that occurs during `speakeasy run` will automatically handle documentation regeneration. * Leaves the `docs` target, but with an added `go mod download` command to prevent Go errors in case anyone wants to make purely Terraform provider documentation changes outside what Speakeasy generates.
JonsSpaghetti
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change accomplishes the following in the
Makefile:speakeasytargetspeakeasyCLI command fromgenerate sdktorun. This is recommended to ensure all generation features run as expected, such as Terraform provider code compilation.docstarget from the default target. The compilation that occurs duringspeakeasy runwill automatically handle documentation regeneration.docstarget, but with an addedgo mod downloadcommand to prevent Go errors in case anyone wants to make purely Terraform provider documentation changes outside what Speakeasy generates.