Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams order, use format: "set" for streams #111

Closed
wants to merge 1 commit into from

Conversation

szemek
Copy link
Contributor

@szemek szemek commented Jun 11, 2024

Fixes #83

@lucasmazza
Copy link

We tested this diff on our setup (following the Testing the provider locally instructions on the README) and it fixes the noisy plan diffs we get on connections with a lot of streams. Thanks so much for the patch.

What else do we need to get this merged and released?

@dholleran-volt
Copy link

@JonsSpaghetti @bgroff could you guys have a look when you get a chance?

@szemek
Copy link
Contributor Author

szemek commented Jul 10, 2024

@lucasmazza @dholleran-volt I'm in touch with Airbyte team. I got info from @marcosmarxm that @perangel will be back on July 15th from his PTO and he'll take care of it.

@perangel
Copy link
Contributor

I have PR up #128 with the proposed changes. There is a link to the branch that has the fully generated provider source that you can use to run it locally to verify if it fixes your use case

@szemek
Copy link
Contributor Author

szemek commented Jul 21, 2024

#128 fixed #83. I'm closing this pull request.

@szemek szemek closed this Jul 21, 2024
@szemek szemek deleted the streams-format-set branch July 21, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streams order changed between terraform plan and apply
4 participants