Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-jira): upgrade to CDK v6 to use concurrency for incremental streams #48425

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 8, 2024

What

This PR upgrades the CDK to version 6 and leverages its concurrency capabilities to enhance the handling of incremental streams. Additionally, it introduces substream state migration to ensure reliable data synchronization.

How

CDK Upgrade & Concurrency Enhancements:

  • Upgraded CDK from version 5 to version 6 to support concurrent processing of multiple incremental streams, enhancing performance and efficiency.
  • Updated configuration files and dependencies to accommodate changes introduced in CDK v6.

Substream State Migration:

  • Implemented state migration logic within the PerPartitionWithFallback class to handle incremental dependencies.
  • Modified the set_initial_state method to ensure that parent streams correctly inherit state from child streams during the initial sync.

Review guide

User Impact

Fix error with substreams failing with retry error after the previous update because of rereading parent stream.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:13pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira labels Nov 8, 2024
@tolik0
Copy link
Contributor Author

tolik0 commented Nov 8, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (db38ecc)

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 8, 2024
@tolik0 tolik0 self-assigned this Nov 8, 2024
@tolik0 tolik0 requested a review from a team November 8, 2024 15:42
@tolik0 tolik0 marked this pull request as ready for review November 8, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants