Bulk Load CDK: Root-Level Flattening & S3V2 Usage #48377
Merged
+444
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
edgao
approved these changes
Nov 7, 2024
| ) | ||
| ) | ||
| if (flatten) { | ||
| (schema as ObjectType).properties.forEach { (name, field) -> properties[name] = field } |
There was a problem hiding this comment.
maybe we should throw if a property clashes with an airbyte field? (honestly not sure, I've never figured out what the expected behavior is for people chaining source -> airbyte -> destination -> airbyte -> destination)
| @@ -60,6 +61,19 @@ class AirbyteValueWithMetaToOutputRecord { | |||
| } | |||
| } | |||
|
|
|||
| fun AirbyteValue.maybeUnflatten(wasFlattened: Boolean): ObjectValue { | |||
| this as ObjectValue | |||
There was a problem hiding this comment.
nit: remove this? (unless it's for the sake of doing a smart cast, in which case add a comment? or maybe define this as fun ObjectValue.maybeUnflatten)
| is DateValue -> value.value | ||
| is IntValue -> value.value.toString() | ||
| is TimeValue -> value.value | ||
| is UnknownValue -> "" |
There was a problem hiding this comment.
I think we should preserve the original json for unknown value?
| import io.airbyte.cdk.load.data.UnknownType | ||
| import io.airbyte.cdk.load.data.json.toAirbyteValue | ||
| import io.airbyte.cdk.load.util.deserializeToNode | ||
| import org.apache.commons.csv.CSVRecord | ||
|
|
||
| class CsvRowToAirbyteValue { | ||
| fun convert(row: CSVRecord, schema: AirbyteType): AirbyteValue { | ||
| print("converting row: $row") |
There was a problem hiding this comment.
Suggested change
| print("converting row: $row") |
johnny-schmidt
force-pushed
the
jschmidt/s3v2/issue-10511/add-mappers-to-formatting-writers
branch
from
25e79bd
to
99e4115
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/issue-10580/root-level-flattening
branch
from
e3fea36
to
45a6f89
Compare
Base automatically changed from
jschmidt/s3v2/issue-10511/add-mappers-to-formatting-writers
to
master
November 7, 2024 19:29
johnny-schmidt
force-pushed
the
jschmidt/s3v2/issue-10580/root-level-flattening
branch
from
45a6f89
to
1b09fbf
Compare
johnny-schmidt
deleted the
jschmidt/s3v2/issue-10580/root-level-flattening
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds support for root-level flattening to ObjectStorage + S3V2 usage (configurable for Json/CSV, required for Avro/Parquet).
Root level flattening means that the client fields are written to the top level of the resulting record instead of to an
_airbyte_datasubfield.So given the client data
{"id": 1, "name": "Bob"}{"_airbyte_raw_id": "<uuid>", "_airbyte_generation_id": 10, ..., "id": 1, "name": "Bob" }{"_airbyte_raw_id": "<uuid>", "_airbyte_generation_id": 10, ..., "_airbyte_data": { "id": 1, "name": "Bob" } }Specifically
schema -> schema with metaandrecord -> record data with meta