Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-tinyemail contribution from ombhardwajj #48031

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ombhardwajj
Copy link
Contributor

@ombhardwajj ombhardwajj commented Oct 31, 2024

This closes #47971

What

This PR adds a new connector for source Tinyemail (source-tinyemail).

Contributor-provided connector description:

Tinyemail is an email marketing tool.
We can extract data from campaigns and contacts streams using this connector.
Docs : https://docs.tinyemail.com/docs/tiny-email/tinyemail

Details

Expand for list of spec properties and streams

Configuration

Input Type Description Default Value
api_key string API Key.

Streams

Stream Name Primary Key Pagination Supports Full Sync Supports Incremental
campaigns id DefaultPaginator
contacts id No pagination
sender_details No pagination
contact_members No pagination

Reviewer checklist

  • Run /format-fix to resolve any formatting errors
  • Help the contributor upload an icon that follows our icon design guidelines
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Oct 31, 2024

@ombhardwajj is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@marcosmarxm
Copy link
Member

All contributions must be merged by Nov-14. I'm going to work to provide a first review by Friday to give users the weekend to fix any comment. Please be aware of this.

Make sure you have pagination properly working, the API doesn't have pagination please left a comment making my review easier.
Make sure have a square svg icon
Make sure credentials are valid.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sender and contact details endpoint for the tiny email connector.

@marcosmarxm
Copy link
Member

Moving next check to Nov 11

@ombhardwajj
Copy link
Contributor Author

I've added the sender details endpoint , contacts was already there. Assuming that by contact details you meant contact_members endpoint , I've added that aswell now !!

@ombhardwajj
Copy link
Contributor Author

Please try to review this on priority , if possible today itself as my access to this API is gonna get lost very soon
@marcosmarxm

@ombhardwajj
Copy link
Contributor Author

@marcosmarxm Please review it today 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/tinyemail hack-2024-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector-request] Tinyemail
3 participants