Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-invoiceninja contribution from ombhardwajj #47675

Conversation

ombhardwajj
Copy link
Contributor

@ombhardwajj ombhardwajj commented Oct 28, 2024

Closes #47635

What

This PR adds a new connector for source Invoiceninja (source-invoiceninja).

Contributor-provided connector description:

Invoice Ninja is an invoicing, billing, and payment management software.
With this connector we can extract data from various streams such asproducts , invoice , payments and quotes.
Docs : https://api-docs.invoicing.co/#overview--introduction

Details

Expand for list of spec properties and streams

Configuration

Input Type Description Default Value
api_key string API Key.

Streams

Stream Name Primary Key Pagination Supports Full Sync Supports Incremental
clients id DefaultPaginator
products id DefaultPaginator
invoices id DefaultPaginator
recurring invoices id DefaultPaginator
payments id DefaultPaginator
quotes id DefaultPaginator
credits id DefaultPaginator
projects id DefaultPaginator
tasks id DefaultPaginator
vendors id DefaultPaginator
purchase_orders id DefaultPaginator
expenses id DefaultPaginator
recurring expenses id DefaultPaginator
bank transactions id DefaultPaginator

Reviewer checklist

  • Run /format-fix to resolve any formatting errors
  • Help the contributor upload an icon that follows our icon design guidelines
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Oct 28, 2024

@ombhardwajj is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@marcosmarxm
Copy link
Member

I couldn't test the connector in your workspace, please check credentials and let me know.

@ombhardwajj
Copy link
Contributor Author

Hey @marcosmarxm
I've fixed that. You can now try to test the connector 😄

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination is not right, it must be page incremental instead of offset.

@ombhardwajj
Copy link
Contributor Author

Correction made 🙇 , apologies for the inadvertent oversight!
@marcosmarxm

@marcosmarxm
Copy link
Member

All contributions must be merged by Nov-14. I'm going to work to provide a first review by Friday to give users the weekend to fix any comment. Please be aware of this.

Make sure you have pagination properly working, the API doesn't have pagination please left a comment making my review easier.
Make sure have a square svg icon
Make sure credentials are valid.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:45pm

@marcosmarxm marcosmarxm enabled auto-merge (squash) November 8, 2024 13:45
@marcosmarxm marcosmarxm merged commit 65e2d00 into airbytehq:master Nov 8, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/invoiceninja hack-2024-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector-request] Invoiceninja
3 participants