-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-simfin contribution from ombhardwajj #47397
base: master
Are you sure you want to change the base?
source-simfin contribution from ombhardwajj #47397
Conversation
@ombhardwajj is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing couples endpoints as this is a very simple API. Without missing endpoints and implementing a better way to retrieve data from symbols.
Moving review to nov 13 |
All contributions must be merged by Nov-14. I'm going to work to provide a first review by Friday to give users the weekend to fix any comment. Please be aware of this. Make sure you have pagination properly working, the API doesn't have pagination please left a comment making my review easier. |
I've added companies, common shares outstanding , weighted shares outstanding , filings by company and filings list streams. |
This closes #47395
What
This PR adds a new connector for source SimFin (source-simfin).
Contributor-provided connector description:
Simfin provides financial data .
With this connector we can extract data from price data , financial statements and company info streams .
Docs https://simfin.readme.io/reference/getting-started-1
Details
Expand for list of spec properties and streams
Configuration
api_key
string
Streams
Reviewer checklist
/format-fix
to resolve any formatting errors