Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-simfin contribution from ombhardwajj #47397

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ombhardwajj
Copy link
Contributor

@ombhardwajj ombhardwajj commented Oct 26, 2024

This closes #47395

What

This PR adds a new connector for source SimFin (source-simfin).

Contributor-provided connector description:

Simfin provides financial data .
With this connector we can extract data from price data , financial statements and company info streams .
Docs https://simfin.readme.io/reference/getting-started-1

Details

Expand for list of spec properties and streams

Configuration

Input Type Description Default Value
api_key string API Key.

Streams

Stream Name Primary Key Pagination Supports Full Sync Supports Incremental
Company Info id No pagination
Financial Statements No pagination
Price Data No pagination
companies No pagination
common_shares_outstanding No pagination
weighted_shares_outstanding No pagination
filings_by_company filingIdentifier No pagination
filings_list filingIdentifier DefaultPaginator

Reviewer checklist

  • Run /format-fix to resolve any formatting errors
  • Help the contributor upload an icon that follows our icon design guidelines
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Oct 26, 2024

@ombhardwajj is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing couples endpoints as this is a very simple API. Without missing endpoints and implementing a better way to retrieve data from symbols.

@marcosmarxm
Copy link
Member

Moving review to nov 13

@marcosmarxm
Copy link
Member

All contributions must be merged by Nov-14. I'm going to work to provide a first review by Friday to give users the weekend to fix any comment. Please be aware of this.

Make sure you have pagination properly working, the API doesn't have pagination please left a comment making my review easier.
Make sure have a square svg icon
Make sure credentials are valid.

@ombhardwajj
Copy link
Contributor Author

ombhardwajj commented Nov 8, 2024

I've added companies, common shares outstanding , weighted shares outstanding , filings by company and filings list streams.
I dont think Utils streams serve any practical value since the companies are already listed by their latest/current name.
Also for company info and financial statements only verbose endpoint has been implemented since it contains all the data (compact endpoint has a subset of the data returned by verbose endpoint)
🙇
@marcosmarxm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/simfin hack-2024-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector-request] SimFin
3 participants