Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(source-shopify): raise exception on missing stream #46578

Merged
merged 3 commits into from
Oct 9, 2024
Merged

ref(source-shopify): raise exception on missing stream #46578

merged 3 commits into from
Oct 9, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Oct 8, 2024 •
edited
Loading

What

Following #46310
Resolving https://github.com/airbytehq/airbyte-internal-issues/issues/10082

How

removed the raise_exception_on_missing_stream override at the source level, since we have this value set to False by default, no need to override the attribute on top of that

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@artem1205 artem1205 self-assigned this Oct 8, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:33pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 8, 2024
@artem1205 artem1205 marked this pull request as ready for review October 9, 2024 11:42
@artem1205 artem1205 requested review from bazarnov and a team October 9, 2024 11:42
@bazarnov
Copy link
Collaborator

bazarnov commented Oct 9, 2024 •
edited
Loading

@artem1205

Based on the description:

set raise_exception_on_missing_stream to True

for the Shopify source, we should keep this set to False.

Having this method set to False by default, on the CDK side makes sense to me, and the change as well, but the description doesn't correspond to the actual change.

Let's change the description to something like:

removed the raise_exception_on_missing_stream override at the source level, since we have this value set to False by default, no need to override the attribute on top of that

bazarnov
bazarnov approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the description.

@artem1205
Copy link
Collaborator Author

artem1205 commented Oct 9, 2024 •
edited by github-actions bot
Loading

/approve-regression-tests

Check job output.

✅ Approving regression tests

@artem1205 artem1205 merged commit 1b49022 into master Oct 9, 2024
41 checks passed
@artem1205 artem1205 deleted the artem1205/source-shopify-raise-exception branch October 9, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem1205 @bazarnov @octavia-squidington-iii