✨ Source Instagram: add new fields for streams StoryInsights and MediaInsights #41937

im-voracity · 2024-07-13T22:10:43Z

What

New metrics for StoryInsights and MediaInsights streams:
StoryInsights: follows, profile_visits, shares, total_interactions.
MediaInsights: follows, profile_visits, clips_replay_count, ig_reels_aggregated_all_plays_count.
Also changed description for ig_reels_avg_watch_time and ig_reels_video_view_total_time that were wrong, since Instagram uses milliseconds for those metrics and not seconds.
Issue: #40610

How

Added new fields to requests query, updated schemas and tests to reflect the changes.

Review guide

source-instagram/schemas/media_insights.json
source-instagram/schemas/story_insights.json
source-instagram/source_instagram/manifest.yaml
source-instagram/unit_tests/resource/
source-instagram/unit_tests/resource/http/response/media_insights_for_carousel_album.json
source-instagram/unit_tests/resource/http/response/media_insights_for_general_media.json
source-instagram/unit_tests/resource/http/response/media_insights_for_reels.json
airbyte-integrations/connectors/source-instagram/unit_tests/resource/http/response/media_insights_for_video.json
source-instagram/unit_tests/resource/http/response/story_insights_for_story_insights_happy_path.json

User Impact

New metrics available for affected streams

Can this PR be safely reverted and rolled back?

YES 💚
NO ❌

Context: Some metrics were deprecated in newer versions of instagram API and although the connector removed the deprecated fields, it didn't added the new metrics available. This PR focus on bringing some of them, since the remaining ones are more complex.

API Reference for all the metrics available can be found here.

…ights

vercel · 2024-07-13T22:10:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 29, 2024 2:30pm

CLAassistant · 2024-07-13T22:10:49Z

All committers have signed the CLA.

natikgadzhi · 2024-07-14T15:45:03Z

/format-fix

Format-fix job started... Check job output.

❌ Job failed.

natikgadzhi · 2024-07-14T15:45:26Z

Thank you for this! Let me run CI on this and fix formatting, let's see how things look then

im-voracity · 2024-07-14T19:56:49Z

Do I have to do something to allow you to run this?

It seems it tried to run on my repo and got an error because of that

natikgadzhi · 2024-07-20T00:03:00Z

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (c8609de)

im-voracity · 2024-07-25T14:48:29Z

Any updates on this review?

natikgadzhi · 2024-07-27T02:46:27Z

The changes make sense to me, but the team that owns Instagram is pretty backlogged. ;(

@bazarnov maybe I can convince you resolve the conflicts and take a look? ;)

bazarnov · 2024-07-29T11:20:31Z

@natikgadzhi No problem; I'll take a look. However, this is a private repo I don't have access to. Thus, the conflicts must be resolved by the repo maintainer @im-voracity (I believe this is you). Merging with master (pull) is enough to list and resolve the conflicts (there are a couple of lines of code to accept and move your changes on top of it).

bazarnov

The changes look good to me, this is not a Breaking Change, thus we should be safe to proceed.

@im-voracity Poke @marcosmarxm when the conflicts are resolved from your side, please.

Thank you for the contribution!

marcosmarxm

LGTM!

marcosmarxm · 2024-07-29T14:57:48Z

Hello your feedback matters a lot to us. Can you spare just 2 minutes to complete a survey? We’re dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve!

…aInsights (airbytehq#41937) Co-authored-by: Natik Gadzhi <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>

im-voracity added 5 commits July 13, 2024 03:38

source-instagram update: new metrics for media_insights and story_ins…

054ebaa

…ights

Merge branch 'airbytehq:master' into instagram-connector-update

344e429

updated docs for instagram connector

33a5974

Fixed typo in source_instagram/schemas/media_insights.json

545841b

Updated docs for Instagram Source

cca5fce

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/instagram labels Jul 13, 2024

im-voracity temporarily deployed to community-ci-auto July 13, 2024 22:11 — with GitHub Actions Inactive

im-voracity had a problem deploying to community-ci-auto July 13, 2024 22:11 — with GitHub Actions Failure

im-voracity had a problem deploying to community-ci July 13, 2024 22:11 — with GitHub Actions Error

vercel bot deployed to Preview July 13, 2024 22:14 View deployment

Updated PR ID in docs/integrations/sources/instagram.md

ac488f0

im-voracity temporarily deployed to community-ci July 13, 2024 22:26 — with GitHub Actions Inactive

im-voracity temporarily deployed to community-ci-auto July 13, 2024 22:26 — with GitHub Actions Inactive

im-voracity had a problem deploying to community-ci-auto July 13, 2024 22:26 — with GitHub Actions Failure

vercel bot deployed to Preview July 13, 2024 22:30 View deployment

Merge branch 'master' into instagram-connector-update

183a8dd

im-voracity had a problem deploying to community-ci-auto July 15, 2024 20:41 — with GitHub Actions Failure

im-voracity had a problem deploying to community-ci July 15, 2024 20:41 — with GitHub Actions Error

im-voracity temporarily deployed to community-ci-auto July 15, 2024 20:41 — with GitHub Actions Inactive

im-voracity temporarily deployed to community-ci July 18, 2024 17:52 — with GitHub Actions Inactive

vercel bot deployed to Preview July 18, 2024 17:57 View deployment

Merge branch 'master' into instagram-connector-update

a0a9813

natikgadzhi had a problem deploying to community-ci-auto July 20, 2024 00:03 — with GitHub Actions Error

natikgadzhi had a problem deploying to community-ci July 20, 2024 00:03 — with GitHub Actions Error

natikgadzhi had a problem deploying to community-ci-auto July 20, 2024 00:03 — with GitHub Actions Error

natikgadzhi had a problem deploying to community-ci July 20, 2024 00:03 — with GitHub Actions Error

chore: auto-fix lint and format issues

c8609de

octavia-approvington temporarily deployed to community-ci July 20, 2024 00:06 — with GitHub Actions Inactive

octavia-approvington temporarily deployed to community-ci-auto July 20, 2024 00:06 — with GitHub Actions Inactive

natikgadzhi enabled auto-merge (squash) July 20, 2024 00:14

im-voracity requested a review from marcosmarxm July 20, 2024 01:03

bazarnov approved these changes Jul 29, 2024

View reviewed changes

Merge branch 'master' into instagram-connector-update

8354da7

marcosmarxm temporarily deployed to community-ci-auto July 29, 2024 14:25 — with GitHub Actions Inactive

marcosmarxm temporarily deployed to community-ci July 29, 2024 14:25 — with GitHub Actions Inactive

marcosmarxm temporarily deployed to community-ci-auto July 29, 2024 14:25 — with GitHub Actions Inactive

marcosmarxm temporarily deployed to community-ci July 29, 2024 14:25 — with GitHub Actions Inactive

vercel bot deployed to Preview July 29, 2024 14:30 View deployment

marcosmarxm approved these changes Jul 29, 2024

View reviewed changes

natikgadzhi merged commit b4bda3b into airbytehq:master Jul 29, 2024
33 checks passed

im-voracity deleted the instagram-connector-update branch July 29, 2024 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source Instagram: add new fields for streams StoryInsights and MediaInsights #41937

✨ Source Instagram: add new fields for streams StoryInsights and MediaInsights #41937

im-voracity commented Jul 13, 2024

vercel bot commented Jul 13, 2024 •

edited

Loading

CLAassistant commented Jul 13, 2024 •

edited

Loading

natikgadzhi commented Jul 14, 2024 •

edited by github-actions bot

Loading

natikgadzhi commented Jul 14, 2024

im-voracity commented Jul 14, 2024 •

edited

Loading

natikgadzhi commented Jul 20, 2024 •

edited by github-actions bot

Loading

im-voracity commented Jul 25, 2024

natikgadzhi commented Jul 27, 2024

bazarnov commented Jul 29, 2024

bazarnov left a comment

marcosmarxm left a comment

marcosmarxm commented Jul 29, 2024

✨ Source Instagram: add new fields for streams StoryInsights and MediaInsights #41937

✨ Source Instagram: add new fields for streams StoryInsights and MediaInsights #41937

Conversation

im-voracity commented Jul 13, 2024

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

vercel bot commented Jul 13, 2024 • edited Loading

CLAassistant commented Jul 13, 2024 • edited Loading

natikgadzhi commented Jul 14, 2024 • edited by github-actions bot Loading

natikgadzhi commented Jul 14, 2024

im-voracity commented Jul 14, 2024 • edited Loading

natikgadzhi commented Jul 20, 2024 • edited by github-actions bot Loading

im-voracity commented Jul 25, 2024

natikgadzhi commented Jul 27, 2024

bazarnov commented Jul 29, 2024

bazarnov left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Jul 29, 2024

vercel bot commented Jul 13, 2024 •

edited

Loading

CLAassistant commented Jul 13, 2024 •

edited

Loading

natikgadzhi commented Jul 14, 2024 •

edited by github-actions bot

Loading

im-voracity commented Jul 14, 2024 •

edited

Loading

natikgadzhi commented Jul 20, 2024 •

edited by github-actions bot

Loading