Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨Source Outbrain Amplify: Migrate to poetry #41035

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Migrating to poetry

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this Jul 8, 2024
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 9:07pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/outbrain-amplify labels Jul 8, 2024
@btkcodedev
Copy link
Collaborator Author

Currently the CDK is set <1, to make the CI pass, It will fail due to deprecated authenticators with version above 1, We can fix it with another PR

@btkcodedev
Copy link
Collaborator Author

@ChristoGrab All checks passed

@btkcodedev
Copy link
Collaborator Author

@ChristoGrab, is everything fine for this?

@ChristoGrab
Copy link
Contributor

@btkcodedev Sorry for the delay; our sandbox creds are expired and I can't log in to the account, so I tried running regression tests against a live connection. No data was being fetched, but according to the tests this was also true when running the existing connector. So even though I can't fully verify the connector works I don't have any reason to believe we've broken anything 😅

@natikgadzhi I'm of the opinion we merge since this is not a high-use connector and I have no evidence we've broken anything that works, any objections? Link to regression test results

@natikgadzhi natikgadzhi enabled auto-merge (squash) July 9, 2024 18:15
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristoGrab feel free to approve those yourself, too!

@natikgadzhi natikgadzhi merged commit 8757e21 into master Jul 9, 2024
36 checks passed
@natikgadzhi natikgadzhi deleted the btkcodedev/outbrainAmplify branch July 9, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/outbrain-amplify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants