-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨Source Outbrain Amplify: Migrate to poetry #41035
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Currently the CDK is set <1, to make the CI pass, It will fail due to deprecated authenticators with version above 1, We can fix it with another PR |
@ChristoGrab All checks passed |
@ChristoGrab, is everything fine for this? |
@btkcodedev Sorry for the delay; our sandbox creds are expired and I can't log in to the account, so I tried running regression tests against a live connection. No data was being fetched, but according to the tests this was also true when running the existing connector. So even though I can't fully verify the connector works I don't have any reason to believe we've broken anything 😅 @natikgadzhi I'm of the opinion we merge since this is not a high-use connector and I have no evidence we've broken anything that works, any objections? Link to regression test results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristoGrab feel free to approve those yourself, too!
What
Migrating to poetry
Can this PR be safely reverted and rolled back?