-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Instagram: Migrate Instagram sources Media, User, UserLiftimelnsights and Stories to low-code #39504
✨ Source Instagram: Migrate Instagram sources Media, User, UserLiftimelnsights and Stories to low-code #39504
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
70303c3
to
47ea8a4
Compare
airbyte-integrations/connectors/source-instagram/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
@@ -7,7 +7,7 @@ data: | |||
connectorSubtype: api | |||
connectorType: source | |||
definitionId: 6acf6b55-4f1e-4fca-944e-1a3caef8aba8 | |||
dockerImageTag: 3.0.10 | |||
dockerImageTag: 3.0.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run live tests on a few connections without a problem. I don't know if this implies that my changes wouldn't need to be breaking changes. The new thing is the Api parent Stream (description), which passes the buz accounts to (now) child Streams. Anyway, I will hear experience call on this matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the state, config and record outputs all have the same format and it does not add relatively big features, I would consider this a patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once there are no regressions in terms of a breaking change, there is no need to make a major
update, but the patch
. @aldogonzalez8 FYI
airbyte-integrations/connectors/source-instagram/pyproject.toml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-instagram/source_instagram/components.py
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,732 @@ | |||
version: 1.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btkcodedev see? When you make a connector in Builder, it's supposed to use the new CDK ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Will prune Docker volumes and fetch new for next one
For live tests, here you can find an analysis I did of the failing test test_catalog_are_the_same https://www.loom.com/share/3d994c40315c4dc78cfb6f2f904da1d1 Cc @maxi297 in case you are reviewing and saw those results |
…ependency on regular transformations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
This will be merged on June 24th, early in the Morning. |
…elnsights and Stories to low-code (#39504) Co-authored-by: Natik Gadzhi <[email protected]>
What
We want to migrate certified connectors to low-code; in this case, it is Instagram Connector. We are initially migrating the following streams:
Follow up in the next PR:
Important: The original implementation used an api object to slice by user business accounts on all the Streams. To achieve this functionality I have created a new Api source that gets this information as pass it to other streams as a parent so they will slice by each account
How
I have followed this guide.
TLDR is the following
Review guide
a. Fetch data for children field of Media; children are an array of media IDs that require their own data, so we go through the list to update the original children's object.
b. Clear URL params "_nc_rid" and "ccb"
c. convert breakdown list to an object
User Impact
Can this PR be safely reverted and rolled back?