Do not stop processing file on parsing error #29679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girarda
approved these changes
Aug 21, 2023
airbyte-cdk/python/unit_tests/sources/file_based/stream/test_default_file_based_stream.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/stream/test_default_file_based_stream.py
Outdated
Show resolved
Hide resolved
airbyte-cdk/python/unit_tests/sources/file_based/stream/test_default_file_based_stream.py
Outdated
Show resolved
Hide resolved
maxi297
deleted the
maxi297/s3-rollout-processing-discrepancy-where-v4-stops-and-not-v3
branch
harrytou
pushed a commit
to KYVENetwork/airbyte
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We had file opening error where V3 would continue processing the files but V4 would stop processing the stream slice. We need not to break to avoid a breaking change. Eventually, we will fix this behavior but outside of V4 release (issue is #29680)