Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Serpstat #28147

Merged
merged 15 commits into from
Aug 22, 2023
Merged

🎉 New Source: Serpstat #28147

merged 15 commits into from
Aug 22, 2023

Conversation

alex-danilin
Copy link
Contributor

What

The initial release of Serpstat source connector related to #28082

How

The initial release of Serpstat source connector

Pre-merge Actions

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/serpstat labels Jul 11, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Jul 12, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, sorry the delay to review the contribution.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-danilin I have a sandbox account and the connector is working. One comment and it's almost done!! Thanks for the contribution.

@marcosmarxm
Copy link
Member

@alex-danilin when I'm testing the connector I keep getting errors. Can you investigate that? Particularly for Domain History.

{
  "status": 200,
  "body": {
    "id": "2023-08-04 13:50:27.856314+00:00",
    "error": {
      "code": 32000,
      "message": "Too Many Requests",
      "data": null
    }
  },

Updating the Stop condition to:
{{response.result.summary_info.page > config['pages_to_fetch'] - 1 if response.result else None}} Helped but didn't fix the main problem.
Probably implementing a response filter can help:
image

@alex-danilin
Copy link
Contributor Author

@marcosmarxm I've added "Too many requests" handling to my latest commit as you proposed. Can you please check and if the issue still exists please send me the connector setting that you are using for me to reproduce it exactly as you have.

@marcosmarxm
Copy link
Member

@alex-danilin can you allow me to push code changes to your branch? There are a few updates need to be done in your code.

@alex-danilin
Copy link
Contributor Author

@marcosmarxm I've sent you the invite to my branch and fixed all the points you mentioned. Check, please.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @alex-danilin

@marcosmarxm marcosmarxm merged commit ad5ba6e into airbytehq:master Aug 22, 2023
31 of 33 checks passed
@alex-danilin
Copy link
Contributor Author

@marcosmarxm Thanks for your assistance.

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Co-authored-by: Marcos Marx <[email protected]>
Co-authored-by: marcosmarxm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/serpstat team/tse Technical Support Engineers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants