Skip to content

Commit

Permalink
fix(connector-insights): ignore CI report if it does not exist (#44429)
Browse files Browse the repository at this point in the history
Co-authored-by: Octavia Squidington III <[email protected]>
  • Loading branch information
natikgadzhi and octavia-squidington-iii authored Aug 20, 2024
1 parent 3c6a88c commit ec0c2fb
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
3 changes: 3 additions & 0 deletions airbyte-ci/connectors/connectors_insights/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ This CLI is currently running nightly in GitHub Actions. The workflow can be fou

## Changelog

### 0.3.2
Bugfix: Ignore CI on master report if it's not accessible.

### 0.3.1
Skip manifest inferred insights when the connector does not have a `manifest.yaml` file.

Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/connectors_insights/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "connectors-insights"
version = "0.3.1"
version = "0.3.2"
description = ""
authors = ["Airbyte <[email protected]>"]
readme = "README.md"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,13 @@ def get_ci_on_master_report(connector: Connector) -> Dict | None:
except (IndexError, KeyError, TypeError):
continue
json_report_url = report_url.replace(".html", ".json")
# The first table entry is the latest report
json_report = get_ci_json_report(json_report_url)
if json_report["connector_version"] == connector.version:
return json_report
# The first table entry is the latest report, but sometimes it's not there questionmark
try:
json_report = get_ci_json_report(json_report_url)
if json_report["connector_version"] == connector.version:
return json_report
except Exception as e:
continue
return None

return None

0 comments on commit ec0c2fb

Please sign in to comment.