Renamed Target position methods

combined conditionals for cleanliness
airbytehq · Aug 21, 2023 · a275611 · a275611
1 parent 143a24a
commit a275611
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/...ions/bases/debezium/src/main/java/io/airbyte/integrations/debezium/CdcTargetPosition.java b/...ions/bases/debezium/src/main/java/io/airbyte/integrations/debezium/CdcTargetPosition.java
@@ -61,7 +61,7 @@ default boolean isHeartbeatSupported() {
    * @param event Event from the CDC load
    * @return Returns `true` when the record is behind the offset. Otherwise, it returns `false`
    */
-  default boolean isRecordBehindOffset(final Map<String, String> offset, final ChangeEventWithMetadata event) {
+  default boolean isEventAheadOffset(final Map<String, String> offset, final ChangeEventWithMetadata event) {
     return false;
   }
 

diff --git a/...main/java/io/airbyte/integrations/debezium/internals/DebeziumStateDecoratingIterator.java b/...main/java/io/airbyte/integrations/debezium/internals/DebeziumStateDecoratingIterator.java
@@ -162,7 +162,7 @@ protected AirbyteMessage computeNext() {
         if (checkpointOffsetToSend.size() == 1
             && changeEventIterator.hasNext()
             && !event.isSnapshotEvent()
-            && targetPosition.isRecordBehindOffset(checkpointOffsetToSend, event)) {
+            && targetPosition.isEventAheadOffset(checkpointOffsetToSend, event)) {
           sendCheckpointMessage = true;
         }
       }

diff --git a/...rc/main/java/io/airbyte/integrations/debezium/internals/mysql/MySqlCdcTargetPosition.java b/...rc/main/java/io/airbyte/integrations/debezium/internals/mysql/MySqlCdcTargetPosition.java
@@ -105,7 +105,7 @@ public boolean isHeartbeatSupported() {
   }
 
   @Override
-  public boolean isRecordBehindOffset(final Map<String, String> offset, final ChangeEventWithMetadata event) {
+  public boolean isEventAheadOffset(final Map<String, String> offset, final ChangeEventWithMetadata event) {
     if (offset.size() != 1) {
       return false;
     }
@@ -126,10 +126,7 @@ public boolean isRecordBehindOffset(final Map<String, String> offset, final Chan
 
   @Override
   public boolean isSameOffset(final Map<String, String> offsetA, final Map<String, String> offsetB) {
-    if (offsetA == null || offsetA.size() != 1) {
-      return false;
-    }
-    if (offsetB == null || offsetB.size() != 1) {
+    if ((offsetA == null || offsetA.size() != 1) || (offsetB == null || offsetB.size() != 1)) {
       return false;
     }
 
@@ -141,11 +138,7 @@ public boolean isSameOffset(final Map<String, String> offsetA, final Map<String,
     final String offsetBFileName = offsetJsonB.get("file").asText();
     final long offsetBPosition = offsetJsonB.get("pos").asLong();
 
-    if (offsetAFileName.compareTo(offsetBFileName) != 0) {
-      return false;
-    }
-
-    return offsetAPosition == offsetBPosition;
+    return offsetAFileName.equals(offsetBFileName) && offsetAPosition == offsetBPosition;
   }
 
   @Override

diff --git a/...n/java/io/airbyte/integrations/debezium/internals/postgres/PostgresCdcTargetPosition.java b/...n/java/io/airbyte/integrations/debezium/internals/postgres/PostgresCdcTargetPosition.java
@@ -94,7 +94,7 @@ public Long extractPositionFromHeartbeatOffset(final Map<String, ?> sourceOffset
   }
 
   @Override
-  public boolean isRecordBehindOffset(final Map<String, String> offset, final ChangeEventWithMetadata event) {
+  public boolean isEventAheadOffset(final Map<String, String> offset, final ChangeEventWithMetadata event) {
     if (offset.size() != 1) {
       return false;
     }