Skip to content

Commit

Permalink
connectors-insights: do no generate insights for scaffolds and strict…
Browse files Browse the repository at this point in the history
… encrypt connectors (#41056)
  • Loading branch information
alafanechere authored Jul 9, 2024
1 parent b2e7895 commit 8be7b7a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
3 changes: 3 additions & 0 deletions airbyte-ci/connectors/connectors_insights/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ This CLI is currently running nightly in GitHub Actions. The workflow can be fou

## Changelog

### 0.2.4
Do not generate insights for `*-scaffold-*` and `*-strict-encrypt` connectors.

### 0.2.3
Share `.docker/config.json` with `syft` to benefit from increased DockerHub rate limit.

Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/connectors_insights/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "connectors-insights"
version = "0.2.3"
version = "0.2.4"
description = ""
authors = ["Airbyte <[email protected]>"]
readme = "README.md"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ async def generate(
)
else:
logger.info(f"Generating insights for {len(connectors)} connectors.")

semaphore = Semaphore(concurrency)
soon_results = []
async with dagger.Connection(dagger.Config(log_output=sys.stderr)) as dagger_client:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,12 @@ def get_all_connectors_in_directory(directory: Path) -> Set[Connector]:
"""
connectors = []
for connector_directory in directory.iterdir():
if connector_directory.is_dir() and (connector_directory / METADATA_FILE_NAME).exists():
connectors.append(Connector(connector_directory.name))
if (
connector_directory.is_dir()
and (connector_directory / METADATA_FILE_NAME).exists()
and "scaffold" not in str(connector_directory)
):
connectors.append(Connector(remove_strict_encrypt_suffix(connector_directory.name)))
return set(connectors)


Expand Down

0 comments on commit 8be7b7a

Please sign in to comment.