Skip to content

Commit

Permalink
Chore: Update "airbyte-lib" CLI references with newer PyAirbyte CLI r…
Browse files Browse the repository at this point in the history
…efs (`pyab validate`) (#46696)
  • Loading branch information
aaronsteers authored Oct 14, 2024
1 parent 95987c7 commit 5114bb5
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 9 deletions.
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,7 @@ airbyte-ci connectors --language=low-code migrate-to-manifest-only

| Version | PR | Description |
| ------- | ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------- |
| 4.39.0 | [#46696](https://github.com/airbytehq/airbyte/pull/46696) | Bump PyAirbyte dependency and replace `airbyte-lib-validate-source` CLI command with new `validate` command |
| 4.38.0 | [#46380](https://github.com/airbytehq/airbyte/pull/46380) | `connectors up-to-date` now supports manifest-only connectors! |
| 4.37.0 | [#46380](https://github.com/airbytehq/airbyte/pull/46380) | Include custom components file handling in manifest-only migrations |
| 4.36.2 | [#46278](https://github.com/airbytehq/airbyte/pull/46278) | Fixed a bug in RC rollout and promote not taking `semaphore` |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from pipelines.models.steps import STEP_PARAMS, Step, StepResult

# Pin the PyAirbyte version to avoid updates from breaking CI
PYAIRBYTE_VERSION = "0.10.2"
PYAIRBYTE_VERSION = "0.18.1"


class PytestStep(Step, ABC):
Expand Down Expand Up @@ -215,7 +215,14 @@ async def _run(self, connector_under_test: Container) -> StepResult:

test_environment = await self.install_testing_environment(with_poetry(self.context))
test_execution = test_environment.with_(
hacks.never_fail_exec(["airbyte-lib-validate-source", "--connector-dir", ".", "--validate-install-only"])
hacks.never_fail_exec(
[
"pyab",
"validate",
f"--connector={self.context.connector.technical_name}",
"--pip-url='.'",
]
)
)

return await self.get_step_result(test_execution)
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "4.38.0"
version = "4.39.0"
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
authors = ["Airbyte <[email protected]>"]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def incompatible_connector(self):
@pytest.fixture
def context_for_valid_connector(self, compatible_connector, dagger_client, current_platform):
context = ConnectorContext(
pipeline_name="test pyairbyte validation",
pipeline_name="CLI smoke test with PyAirbyte",
connector=compatible_connector,
git_branch="test",
git_revision="test",
Expand All @@ -138,7 +138,7 @@ def context_for_valid_connector(self, compatible_connector, dagger_client, curre
@pytest.fixture
def context_for_invalid_connector(self, incompatible_connector, dagger_client, current_platform):
context = ConnectorContext(
pipeline_name="test pyairbyte validation",
pipeline_name="CLI smoke test with PyAirbyte",
connector=incompatible_connector,
git_branch="test",
git_revision="test",
Expand All @@ -155,7 +155,7 @@ async def test__run_validation_success(self, mocker, context_for_valid_connector
result = await PyAirbyteValidation(context_for_valid_connector)._run(mocker.MagicMock())
assert isinstance(result, StepResult)
assert result.status == StepStatus.SUCCESS
assert "Creating source and validating spec is returned successfully..." in result.stdout
assert "Getting `spec` output from connector..." in result.stdout

async def test__run_validation_skip_unpublished_connector(
self,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
remoteRegistries:
pypi:
enabled: false
# TODO: Set enabled=true after `airbyte-lib-validate-source` is passing.
# TODO: Set enabled=true after `pyab validate` is passing.
packageName: airbyte-source-appstore-singer
registryOverrides:
cloud:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
remoteRegistries:
pypi:
enabled: false
# TODO: Set enabled=true after `airbyte-lib-validate-source` is passing.
# TODO: Set enabled=true after `pyab validate` is passing.
packageName: airbyte-source-google-workspace-admin-reports
registryOverrides:
cloud:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
remoteRegistries:
pypi:
enabled: false
# TODO: Set enabled=true after `airbyte-lib-validate-source` is passing.
# TODO: Set enabled=true after `pyab validate` is passing.
packageName: airbyte-source-kustomer-singer
registryOverrides:
cloud:
Expand Down

0 comments on commit 5114bb5

Please sign in to comment.