Destination CDK: Skip flush of zero byte records. (#39106)

airbytehq · Jun 5, 2024 · 3d8f7ca · 3d8f7ca
1 parent 7057fc3
commit 3d8f7ca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/airbyte-cdk/java/airbyte-cdk/README.md b/airbyte-cdk/java/airbyte-cdk/README.md
@@ -174,6 +174,7 @@ corresponds to that version.
 
 | Version | Date       | Pull Request                                               | Subject                                                                                                                                                        |
 |:--------|:-----------|:-----------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 0.36.6  | 2024-06-05 | [\#39106](https://github.com/airbytehq/airbyte/pull/39106) | Skip write to storage with 0 byte file                                                                                                                         |
 | 0.36.5  | 2024-06-01 | [\#38792](https://github.com/airbytehq/airbyte/pull/38792) | Throw config exception if no selectable table exists in user provided schemas                                                                                  |
 | 0.36.4  | 2024-05-31 | [\#38824](https://github.com/airbytehq/airbyte/pull/38824) | Param marked as non-null to nullable in JdbcDestinationHandler for NPE fix                                                                                     |
 | 0.36.2  | 2024-05-29 | [\#38538](https://github.com/airbytehq/airbyte/pull/38357) | Exit connector when encountering a config error.                                                                                                               |

diff --git a/airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties b/airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
@@ -1 +1 @@
-version=0.36.5
+version=0.36.6
diff --git a/...tlin/io/airbyte/cdk/integrations/destination/staging/operation/StagingStreamOperations.kt b/...tlin/io/airbyte/cdk/integrations/destination/staging/operation/StagingStreamOperations.kt
@@ -50,7 +50,11 @@ class StagingStreamOperations<DestinationState : MinimumDestinationState>(
             log.info {
                 "Buffer flush complete for stream ${streamConfig.id.originalName} (${FileUtils.byteCountToDisplaySize(it.byteCount)}) to staging"
             }
-            storageOperation.writeToStage(streamConfig, writeBuffer)
+            if (it.byteCount != 0L) {
+                storageOperation.writeToStage(streamConfig, writeBuffer)
+            } else {
+                log.info { "Skipping writing to storage since there are no bytes to write" }
+            }
         }
     }
 }