Skip to content

Commit

Permalink
CI: Fix fork check condition (#37553)
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronsteers authored Apr 24, 2024
1 parent 9459d4f commit 14820c5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/contractors_review_requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
name: "Check if a review is required from Connector teams"
runs-on: ubuntu-latest

if: ${{ github.event.repository.fork == false }}
if: ${{ github.event.pull_request.head.repo.fork == false }}
# This workflow cannot run on forks, as the fork's github token does not have `read:org`
# permissions, which are required to check the user's team membership. We assume that a
# review on a fork's PR is always required from one or more connector teams and/or support.
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/format_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
(github.event.pull_request.head.repo.fork == false)
runs-on: tooling-test-small
steps:
- name: Checkout Airbyte
- name: Checkout Airbyte (with credentials)
uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
runs-on: ubuntu-latest
steps:
# We have no creds. Ignore docker caching and just run the CLI.
- name: Checkout code
- name: Checkout code (Unprivileged)
uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
Expand All @@ -114,8 +114,8 @@ jobs:
id: install-airbyte-ci-binary
shell: bash
run: |
curl -sSL "https://connectors.airbyte.com/airbyte-ci/releases/ubuntu/latest/airbyte-ci" --output airbyte-ci-bin
sudo mv airbyte-ci-bin /usr/local/bin/airbyte-ci
curl -sSL "https://connectors.airbyte.com/airbyte-ci/releases/ubuntu/latest/airbyte-ci" --output airbyte-ci-bin
sudo mv airbyte-ci-bin /usr/local/bin/airbyte-ci
sudo chmod +x /usr/local/bin/airbyte-ci
- name: Run format checks
run: |
Expand Down

0 comments on commit 14820c5

Please sign in to comment.