Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crossorigin="use-credentials" for manifest files #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 11, 2024

  1. Use crossorigin="use-credentials" for manifest files

    When running Airbyte behind an authentication proxy (in my case, GCP's
    Identity-Aware Proxy), the `manifest.json` request will always fail with a CORS
    error, like:
    
    ```
    Access to manifest at 'https://accounts.google.com/o/oauth2/v2/auth?client_id=465372...' (redirected
    from 'https://airbyte.mydomain.com/manifest.json') from origin
    'https://airbyte.mydomain.com' has been blocked by CORS policy: No
    'Access-Control-Allow-Origin' header is present on the requested resource.
    ```
    brianstorti committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b0c20ef View commit details
    Browse the repository at this point in the history