fix(temporal): use correct property value for temporal.retention #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justenwalker
force-pushed
the
jwalker/fix-temporal-retention
branch
2 times, most recently
from
96ab515
to
6e77655
Compare
benmoriceau
approved these changes
Aug 3, 2023
justenwalker
force-pushed
the
jwalker/fix-temporal-retention
branch
2 times, most recently
from
052db98
to
64f0ea5
Compare
This fixes an issue with setting the default namespace retention back to the default of 30 days Fixes: airbytehq/airbyte#28235 Signed-off-by: Justen Walker <[email protected]>
justenwalker
force-pushed
the
jwalker/fix-temporal-retention
branch
from
64f0ea5
to
37f435a
Compare
|
/create-oss-pr |
|
Thanks for the pr Justen, this has been merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes an issue with setting the default namespace retention back to the default of 30 days
Fixes: airbytehq/airbyte#28235
How
Use the correct
namevalue of the@PropertyannotationRecommended reading order
airbyte-commons-temporal/src/main/java/io/airbyte/commons/temporal/TemporalUtils.java🚨 User Impact 🚨
Probably not