Skip to content

Commit

Permalink
feat(temporal): allow customization of SSL mode for external db
Browse files Browse the repository at this point in the history
Signed-off-by: CyberHippo <[email protected]>
  • Loading branch information
CyberHippo committed Sep 27, 2024
1 parent c95be0b commit 8522db2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
3 changes: 2 additions & 1 deletion charts/airbyte-temporal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Helm chart to deploy airbyte-temporal
| global.configMapName | string | `""` | |
| global.database.secretName | string | `""` | |
| global.database.secretValue | string | `""` | |
| global.database.type | string | `"internal"` | |
| global.database.ssl.enabled | bool | `"true"` | |
| global.deploymentMode | string | `"oss"` | |
| global.extraContainers | list | `[]` | |
| global.extraLabels | object | `{}` | |
Expand Down Expand Up @@ -59,4 +61,3 @@ Helm chart to deploy airbyte-temporal
| service.port | int | `7233` | |
| service.type | string | `"ClusterIP"` | |
| tolerations | list | `[]` | |

14 changes: 8 additions & 6 deletions charts/airbyte-temporal/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,21 +59,23 @@ spec:
value: "config/dynamicconfig/development.yaml"

{{- include "airbyte.temporal.database.envs" . | nindent 10 }}

{{- end }}

{{- if eq .Values.global.database.type "external" }}
# Assume an external database requires SSL.
- name: POSTGRES_TLS_ENABLED
value: "true"
- name: POSTGRES_TLS_DISABLE_HOST_VERIFICATION
value: "true"
- name: SQL_TLS_ENABLED
value: "true"
- name: SQL_TLS_DISABLE_HOST_VERIFICATION
value: "true"
{{- end }}

{{- if .Values.global.database.ssl.enabled }}
- name: POSTGRES_TLS_ENABLED
value: "true"
- name: SQL_TLS_ENABLED
value: "true"
{{- end }}

{{- if .Values.extraEnv }}
{{ .Values.extraEnv | toYaml | nindent 10 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte-temporal/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ global:
extraLabels: {}
database:
type: internal
ssl:
enabled: true
secretName: ""
secretValue: ""

Expand Down

0 comments on commit 8522db2

Please sign in to comment.