Skip to content

Commit

Permalink
feat: automatically set variables enabling SSL for temporal on extern…
Browse files Browse the repository at this point in the history
…al databases. (#13095)

Follow up to airbytehq/oncall#5843.

Here is a suggested approach to automatically enabling SSL if the database type is external.

The assumption here is all external database type databases have SSL turned on.
  • Loading branch information
davinchia committed Aug 2, 2024
1 parent e42711c commit 4731a0b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
13 changes: 13 additions & 0 deletions charts/airbyte-temporal/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,19 @@ spec:
{{- include "airbyte.temporal.database.envs" . | nindent 10 }}

{{- end }}

{{- if eq .Values.global.database.type "external" }}
# Assume an external database requires SSL.
- name: POSTGRES_TLS_ENABLED
value: "true"
- name: POSTGRES_TLS_DISABLE_HOST_VERIFICATION
value: "true"
- name: SQL_TLS_ENABLED
value: "true"
- name: SQL_TLS_DISABLE_HOST_VERIFICATION
value: "true"
{{- end }}

{{- if .Values.extraEnv }}
{{ .Values.extraEnv | toYaml | nindent 10 }}
{{- end }}
Expand Down
1 change: 1 addition & 0 deletions charts/airbyte-temporal/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ global:
## extraLabels [object] - use to specify own additional labels for deployment
extraLabels: {}
database:
type: internal
secretName: ""
secretValue: ""

Expand Down

2 comments on commit 4731a0b

@PurseChicken
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see airbytehq/airbyte#43328

This commit causes issues when using non-ssl external databases. More specifically a sidecar proxy which handles the TLS negotiation external to airbyte.

@film42
Copy link

@film42 film42 commented on 4731a0b Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a breaking change with no opt-out. This should probably be reverted.

Please sign in to comment.