-
Notifications
You must be signed in to change notification settings - Fork 267
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: automatically set variables enabling SSL for temporal on extern…
…al databases. (#13095) Follow up to airbytehq/oncall#5843. Here is a suggested approach to automatically enabling SSL if the database type is external. The assumption here is all external database type databases have SSL turned on.
- Loading branch information
Showing
2 changed files
with
14 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4731a0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see airbytehq/airbyte#43328
This commit causes issues when using non-ssl external databases. More specifically a sidecar proxy which handles the TLS negotiation external to airbyte.
4731a0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a breaking change with no opt-out. This should probably be reverted.