-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolve issue where read()
would fail if it received unexpected/undeclared top-level properties in a stream
#131
Conversation
It looks like at least one root cause of failure is that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I did more digging and found that CI is failing the pokemon integration test, but inexplicably so. In CI, it uses the incorrect endpoint and gets a 404:
Instead of the correct endpoint:
It's not worth debugging at this point since the fix for the core issue is already contained in this PR. I'll open a low-pri issue to resolve. In the meanwhile, we'll just skip this particular test when run in CI. (And if it continues to act up, we can just remove that test entirely.) Update: Logged as: #146 |
read()
would fail if it received unexpected top-level properties in a stream
read()
would fail if it received unexpected top-level properties in a streamread()
would fail if it received unexpected/undeclared top-level properties in a stream
The primary cause for failure in the case of PokeAPI source was a JSON field called
cries
was included in the delivered data, but not in the source's schema.The core fix of this PR is to ensure that our base implementation does not attempt to write fields which are undeclared in the source schema.
Notes: