-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add anonymous user ID in tracking events #124
Conversation
After running PyAirbyte locally, I now have the file as expected:
We write the file as plain text but it is intended to be parsed as yaml. The reason for writing as plain text is that this allows us to more easily control formatting and the header comment text. I realize we still need to have a real URL to point people to. The one above is not a real page as of yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! :) One minor comment, non-blocking.
Resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/6482
This is ready for review.
DO_NOT_TRACK
is not set, a new ID will be generated and will be stored in a yaml file at~/.airbyte/analytics.yml
AIRBYTE_ANALYTICS_ID
env var is set, then the provided ID will be used instead of a randomly generated one. In this case, the provided analytics ID will also be saved to the analytics file, overriding any previously set value.