Skip to content

Commit

Permalink
[Enhancement](inverted index) return OK instead of not supported in e…
Browse files Browse the repository at this point in the history
…xpr evaluate_inverted_index (apache#41567)

## Proposed changes

Fix annoying error stack info
  • Loading branch information
airborne12 committed Oct 9, 2024
1 parent 25684f4 commit 7f11b25
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion be/src/vec/exprs/vexpr.h
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class VExpr {

// execute current expr with inverted index to filter block. Given a roaring bitmap of match rows
virtual Status evaluate_inverted_index(VExprContext* context, uint32_t segment_num_rows) {
return Status::NotSupported("Not supported execute_with_inverted_index");
return Status::OK();
}

Status _evaluate_inverted_index(VExprContext* context, const FunctionBasePtr& function,
Expand Down
3 changes: 1 addition & 2 deletions be/src/vec/functions/function.h
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,7 @@ class IFunctionBase {
const std::vector<vectorized::IndexFieldNameAndTypePair>& data_type_with_names,
std::vector<segment_v2::InvertedIndexIterator*> iterators, uint32_t num_rows,
segment_v2::InvertedIndexResultBitmap& bitmap_result) const {
return Status::NotSupported("evaluate_inverted_index is not supported in function: ",
get_name());
return Status::OK();
}

/// Do cleaning work when function is finished, i.e., release state variables in the
Expand Down

0 comments on commit 7f11b25

Please sign in to comment.