Fix for stacked bars with a mix of strings and numbers in the x-axis #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… order of the data and prevents issues when the x columns are a mix of numbers and strings
reganperkins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
issue
If stacked bars have a mix of string and number values in the x-axis, the order breaks the stacked bars. This makes it look like the data is correct but the values in the data do not match the values shown in the chart.
example
https://codesandbox.io/p/sandbox/vibrant-joana-hht45t
in the example above if you look at L2 Males the tooltips show 10 but the value should really be 30 (ie its showing the values for L2, not 1)
solution
The issue was in
visx/xycharts/lib/utils/combineBarStackDatathe order was being lost due to an object being used to holddataByStackValue. Objects do not follow a consistent ordering. If we change this to use a Map we are guaranteed to have the keys be iterated in order of insertionfix
use a Map rather than an object to store the data, this preserves the order of the data and prevents issues when the x columns are a mix of numbers and strings