Update docker-api #149
Closed
Update docker-api #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and specify logging dependency. I guess docker-api isn't using it anymore, but this gem still does.
|
@cap10morgan re-did this against master in #159. Let me know if that didn't work right :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-api 1.7.x was generating 400 errors trying to talk to a Docker 1.7.x daemon. The latest version of docker-api (1.23.0) speaks a much newer version of the Docker Remote API and fixed this issue. The specs still pass w/ this newer version.
It appears that this used to rely on an implicit logging dependency pulled in by old versions of docker-api, but now it specifies the dependency explicitly because the latest docker-api seems to no longer pull it in.