Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block/allow interfaces #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhuker
Copy link

@zhuker zhuker commented Jun 7, 2022

The following will ignore all docker interfaces when gathering candidates

ice.get_host_addresses(block_list=["docker*"])

The following will only allow ethernet interfaces when gathering candidates

ice.get_host_addresses(block_list=["eth*"])

@sirf
Copy link

sirf commented Sep 22, 2022

The following will only allow ethernet interfaces when gathering candidates

ice.get_host_addresses(block_list=["eth*"])

It should it be allow_list=["eth*"]) right?

@jlaine
Copy link
Collaborator

jlaine commented Apr 1, 2023

I don't plan on merging this as-is as I can see this leading to a proliferation of options for allowing / blocking not only interfaces but specific addresses. Another option would be to introduce a filter_host_addresses callable which you can use to do whatever you want. This could in fact superseed the use_ipv4 and use_ipv6 parameters.

@jlaine jlaine added the changes requested Some changes are required before the PR can be merged. label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Some changes are required before the PR can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants