-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncancel tasks after timeout in python 3.11 #363
Merged
Dreamsorcerer
merged 10 commits into
aio-libs:master
from
tristan:uncancel-cancelled-tasks
Aug 9, 2023
Merged
Uncancel tasks after timeout in python 3.11 #363
Dreamsorcerer
merged 10 commits into
aio-libs:master
from
tristan:uncancel-cancelled-tasks
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 105 116 +11
Branches 18 19 +1
=========================================
+ Hits 105 116 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bdraco
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Sep 28, 2024
effectively the same fix as aio-libs/async-timeout#363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Python 3.11 introduced the concept of uncancelling a cancelled task.
From https://docs.python.org/3/library/asyncio-task.html#task-cancellation
This updates async-timeout to be compliant with python 3.11 when cancelling the tasks after a timeout
Are there changes in behavior for the user?
no
Related issue number
#362
Checklist
Documentation reflects the changesCHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.