Fix all waiters being enumerated on connection release #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2964 changed the waiter implementation to enumerate all the waiters one release. This may be to handle a case where waiters are not properly released, however I could not find one where we should be relesing waiters for other keys when we already have the key
|
This is going to need some more test coverage for different keys |
bdraco
added
backport-3.10
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9421 +/- ##
==========================================
- Coverage 98.57% 98.57% -0.01%
==========================================
Files 107 107
Lines 35048 35044 -4
Branches 4150 4149 -1
==========================================
- Hits 34547 34543 -4
Misses 334 334
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
#2964 changed the waiter implementation to enumerate all the waiters on release. This may be to handle a case where waiters are not properly released, however I could not find one where we should be releasing waiters for other keys when we already have the key
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no