-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package with hatch #856
Package with hatch #856
Conversation
f439c19
to
2a2d1b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #856 +/- ##
==========================================
- Coverage 81.36% 81.34% -0.03%
==========================================
Files 24 24
Lines 1374 1372 -2
Branches 245 245
==========================================
- Hits 1118 1116 -2
Misses 170 170
Partials 86 86 ☔ View full report in Codecov by Sentry. |
Pre-commit only supports Python 3.9+ as of v3.6.0, so I changed the requirement to pre-commit>=3.5.0 in order to support Python 3.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also adopt setuptools_scm
to automate the version mangling based on the latest git tags?
- Remove typing_extensions (used to backport `typing.Literal`) as we now drop support for Python 3.7 or older.
85f09d8
to
a4a1a64
Compare
Since we're using hatchling, I used hatch-vcs, which delivers the same functionality. I've also rebased against master. |
What do these changes do?
This updates pyproject.toml to support new-style packaging with hatch, instead of setuptools / setup.py.
The existing requirements files have been combined into "dependencies" (always installed), "dev" (anything dev, lint, or testing), and "doc" (needed to build the docs). With the optional dependencies, I was trying to follow convention I've seen elsewhere. Feedback would be welcome.
Are there changes in behavior for the user?
Instead of using
pip install -r requirements/...
, the package can now be installed withpip install -e .[dev,doc]
(where "dev" and "doc" are optional dependency groups).Related issue number
848
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.