Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type annotations in core functions #850

Merged
merged 44 commits into from
Jun 25, 2024
Merged

Improve type annotations in core functions #850

merged 44 commits into from
Jun 25, 2024

Commits on May 20, 2024

  1. Explicitly type _do_query() and _query() methods

    @achimnol
    achimnol committed May 20, 2024
    Configuration menu
    Copy the full SHA
    bb62f27 View commit details
    Browse the repository at this point in the history

  2. Revert mistakenly changed code

    @achimnol
    achimnol committed May 20, 2024
    Configuration menu
    Copy the full SHA
    469f81b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into refactor/improve-type-anno-for-query

    @achimnol
    achimnol committed May 20, 2024
    Configuration menu
    Copy the full SHA
    59bcb5f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'master' into refactor/improve-type-anno-for-query

    @achimnol
    achimnol committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5dd7919 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into refactor/improve-type-anno-for-query

    @achimnol
    achimnol authored May 21, 2024
    Configuration menu
    Copy the full SHA
    7e6762b View commit details
    Browse the repository at this point in the history

  3. Strongly type JSON objects 

    This will improve typing when we accept user-provided arguments.
Though, it mandates our users to annotate/cast the return values
explicitly due to type variances.  To completely resolve this issue,
we have to introduce typed DTOs using pydantic or msgspec.
    @achimnol
    achimnol committed May 21, 2024
    Configuration menu
    Copy the full SHA
    782eb16 View commit details
    Browse the repository at this point in the history

  4. Make annotations static

    @achimnol
    achimnol committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5079428 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Merge branch 'master' into refactor/improve-type-anno-for-query

    @achimnol
    achimnol committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    71538c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'master' into refactor/improve-type-anno-for-query 

    - `utils._AsyncCM` is completely removed and replaced with the intrinsic
  `contextlib._AsyncGeneratorContextManager`.
    @achimnol
    achimnol committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6d1b21a View commit details
    Browse the repository at this point in the history

  2. Make type-annotations evaluated only in type checkers

    @achimnol
    achimnol committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    05889ec View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Fix exec/tty related type annotations and type checks

    @achimnol
    achimnol committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b392be6 View commit details
    Browse the repository at this point in the history

  2. Fix Python 3.8 compatibility

    @achimnol
    achimnol committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f017a6a View commit details
    Browse the repository at this point in the history

  3. Improve type-anno

    @achimnol
    achimnol committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    16036a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Remove Python 3.7 compat code

    @achimnol
    achimnol committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    e2ddebe View commit details
    Browse the repository at this point in the history

  2. Improve Python 3.8 compatibility

    @achimnol
    achimnol committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    18edd51 View commit details
    Browse the repository at this point in the history

  3. Clarify platform-specific docker_host inference

    @achimnol
    achimnol committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    ac0cbfc View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Use custom recursive JSON types only for arguments 

    - If they are used in return values, the caller should perform extra
  type-narrowing or casting to pick a final type from union to avoid
  type check failures.
- In a long term, it is better to declare typed DTOs.
    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b2a7067 View commit details
    Browse the repository at this point in the history

  2. Fix the type annotation of DockerImage.list()

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    22e9353 View commit details
    Browse the repository at this point in the history

  3. Try to force cleanup in test fixtures

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d90fe6b View commit details
    Browse the repository at this point in the history

  4. The standard alpine-based Python image works on Windows as well!

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a2f22e1 View commit details
    Browse the repository at this point in the history

  5. Add overload typing to DockerContainer.log() and related tests

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d6232a6 View commit details
    Browse the repository at this point in the history

  6. Try to fix Windows test issue

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e81f5d0 View commit details
    Browse the repository at this point in the history

  7. Close the underlying connector when closing the Docker instance

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0fe9810 View commit details
    Browse the repository at this point in the history

  8. Let's check gc

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5d31afb View commit details
    Browse the repository at this point in the history

  9. Use consistent image names

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5deb9b2 View commit details
    Browse the repository at this point in the history

  10. Pull test docker image before running test

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4813783 View commit details
    Browse the repository at this point in the history

  11. Boost up the image presence check in the fixture

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    25f0dd4 View commit details
    Browse the repository at this point in the history

  12. Remove debug code and add a note about the image size

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    12bc4bd View commit details
    Browse the repository at this point in the history

  13. Apply caching for Docker images

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8fa6eb9 View commit details
    Browse the repository at this point in the history

  14. Use literal annotations

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    fdb5b5d View commit details
    Browse the repository at this point in the history

  15. Clean up docker images produced during tests (prevent caching them)

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d07f033 View commit details
    Browse the repository at this point in the history

  16. Revert image caching and fix the image cleanup command

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    db0cb44 View commit details
    Browse the repository at this point in the history

  17. Add news fragment

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3ca6a6f View commit details
    Browse the repository at this point in the history

  18. Annotate more test codes

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4ce3d30 View commit details
    Browse the repository at this point in the history

  19. Remove use of private API of the ssl module

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    398e04d View commit details
    Browse the repository at this point in the history

  20. Minor code cleanup

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1c51f6a View commit details
    Browse the repository at this point in the history

  21. Fix bug in test (previously hidden due to missing assert)

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    63b339d View commit details
    Browse the repository at this point in the history

  22. Fix again

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c543deb View commit details
    Browse the repository at this point in the history

  23. Annotate test_execs, test_images

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    88412bb View commit details
    Browse the repository at this point in the history

  24. Improve impl/anno/test of utils.clean_filters()

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3b46a3f View commit details
    Browse the repository at this point in the history

  25. Explicitly type monkeypatch fixture

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3c48b61 View commit details
    Browse the repository at this point in the history

  26. Allow passing None to clean_filters

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b461c4c View commit details
    Browse the repository at this point in the history

  27. Update test_clean_filters

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e9ea317 View commit details
    Browse the repository at this point in the history

  28. Enhance annotation of the containers/container API

    @achimnol
    achimnol committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d6ccbe0 View commit details
    Browse the repository at this point in the history