Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED: typing to cached.__call__ #880

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GrafLearnt
Copy link

What do these changes do?

Adds typing support for functions decorated with @cached()

Are there changes in behavior for the user?

No

Related issue number

null

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Dreamsorcerer
Copy link
Member

As mentioned in other issues/PRs, typing won't work in this library until the preceding steps in the milestone are complete: https://github.com/aio-libs/aiocache/milestone/8

Feel free to contribute by picking up the tasks starting from the top of that milestone.

@@ -2,13 +2,17 @@
import functools
import inspect
import logging
from typing import Any, Awaitable, Callable, ParamSpec, TypeVar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to use typing_extensions to support older versions of python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants