Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuner interface update #234

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Tuner interface update #234

merged 7 commits into from
Nov 27, 2023

Conversation

YamLyubov
Copy link
Collaborator

@YamLyubov YamLyubov commented Oct 30, 2023

All tuners now can except the same arguments. Also timer and check for possibility of tuning was added.
#232

@pep8speaks
Copy link

pep8speaks commented Oct 30, 2023

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-27 11:38:54 UTC

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #234 (4fd08ef) into main (52ad420) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 86.86%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   71.88%   71.85%   -0.04%     
==========================================
  Files         136      136              
  Lines        8130     8139       +9     
==========================================
+ Hits         5844     5848       +4     
- Misses       2286     2291       +5     
Files Coverage Δ
golem/core/tuning/hyperopt_tuner.py 97.29% <ø> (-0.27%) ⬇️
golem/core/tuning/iopt_tuner.py 100.00% <100.00%> (ø)
golem/core/tuning/optuna_tuner.py 92.77% <100.00%> (-0.26%) ⬇️
golem/core/tuning/sequential.py 95.45% <94.11%> (+0.06%) ⬆️
golem/core/tuning/simultaneous.py 86.88% <78.94%> (+0.96%) ⬆️
golem/core/tuning/tuner_interface.py 85.81% <79.41%> (-4.87%) ⬇️

... and 5 files with indirect coverage changes

golem/core/tuning/iopt_tuner.py Show resolved Hide resolved
golem/core/tuning/tuner_interface.py Outdated Show resolved Hide resolved
golem/core/tuning/tuner_interface.py Outdated Show resolved Hide resolved
golem/core/tuning/optuna_tuner.py Outdated Show resolved Hide resolved
golem/core/tuning/sequential.py Outdated Show resolved Hide resolved
@YamLyubov YamLyubov merged commit c158212 into main Nov 27, 2023
6 checks passed
@YamLyubov YamLyubov deleted the tuner-interface branch November 27, 2023 11:43
@YamLyubov YamLyubov linked an issue Nov 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tuners interfaces identical
4 participants