Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for the REFTRAJ simpulation #207

Merged
merged 29 commits into from
Mar 6, 2024
Merged

Conversation

cpignedoli
Copy link
Collaborator

TrajectoryData added as spec.inputs to the cp2k plugin.
This is used for REFTRAJECTORY type of calculations.
The input trajectory will trigger teh creation of two input files:
-trajectory.xyz
-reftraj.cell

@cpignedoli cpignedoli marked this pull request as ready for review February 11, 2024 17:28
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cpignedoli, please see my review.

aiida_cp2k/calculations/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/calculations/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/calculations/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/calculations/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/calculations/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/calculations/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/utils/input_generator.py Outdated Show resolved Hide resolved
examples/single_calculations/example_dft_md_reftraj.py Outdated Show resolved Hide resolved
examples/single_calculations/example_dft_md_reftraj.py Outdated Show resolved Hide resolved
@yakutovicha yakutovicha changed the title preliminary version of input trajectory in cp2k plugin Implement support for the REFTRAJ simpulation Mar 6, 2024
yakutovicha
yakutovicha previously approved these changes Mar 6, 2024
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that the issue with the failed work chain must be fixed upstream, we go ahead with a failed test for the moment.

@yakutovicha yakutovicha merged commit 33fd994 into main Mar 6, 2024
5 of 7 checks passed
@yakutovicha yakutovicha deleted the feature/traj-input branch March 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants