Skip to content

Commit

Permalink
issue #33: addressed requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
vivalareda committed Nov 24, 2023
1 parent 6b0df4e commit bc1f18a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/workflow-gh-pages-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ permissions:
contents: write

jobs:
build-and-deploy:
deploy:
runs-on: ubuntu-latest
env:
WORKING_DIR: ${{ inputs.working-dir }}
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/workflow-vercel-deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,3 @@
- **Required Secrets:**
- `VERCEL_TOKEN`: Token for authentication with Vercel, enables interaction with your Vercel account.
- `GITHUB_TOKEN`: Generated by GitHub to enable actions inside the repository, like commenting on pull requests.
- **Workflow Steps:**
- **Checkout Repository**: Gets code from the repository.
- **Install Vercel CLI**: Installs the latest version of the Vercel CLI.
- **Pull Vercel Environment Information**: Fetches environment-specific configurations from Vercel for the preview deployment.
- **Build Project Artifacts**: Builds the project artifacts using the Vercel CLI.
- **Deploy Project Artifacts to Vercel**: Deploys the artifacts to Vercel.
- **Sleep for 10 seconds**: Lets the deployment process complete before commenting the URL.
- **Comment on PR**: Posts a comment on the pull request with the URL.
6 changes: 2 additions & 4 deletions .github/workflows/workflow-vercel-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
pull-requests: write

jobs:
Deploy-Preview-and-Comment:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -25,9 +25,7 @@ jobs:
run: vercel build --token=${{ secrets.VERCEL_TOKEN }}
- name: Deploy Project Artifacts to Vercel
run: vercel deploy --prebuilt --token=${{ secrets.VERCEL_TOKEN }}

- run: sleep 10


- name: Comment on PR
uses: JoseThen/[email protected]
with:
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ Each workflow has an associated documentation file that explains its purpose, us

Here are the available workflows and their associated documentation:

- [Reusable Docker Container
Build](.github/workflows/workflow-build-container.md)
- [Reusable Docker Container Build](.github/workflows/workflow-build-container.md)
- [Reusable Docker Container Deployment to Google Cloud Run](.github/workflows/workflow-deploy-gcp.md)
- [Reusable Lint and Test Workflow for Node (React) Projects](.github/workflows/workflow-lint-test-node.md)
- [Reusable Lint and Test Workflow for Python Projects](.github/workflows/workflow-lint-test-python.md)
Expand Down

0 comments on commit bc1f18a

Please sign in to comment.